-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable turbo drive #16486
Draft
oliverguenther
wants to merge
48
commits into
dev
Choose a base branch
from
experiment/enable-turbo-drive
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Enable turbo drive #16486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
2 times, most recently
from
August 28, 2024 13:04
e441bc1
to
f89c2c8
Compare
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
7 times, most recently
from
September 17, 2024 07:11
e01058b
to
c65b3de
Compare
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
from
October 8, 2024 11:54
c65b3de
to
295ebcc
Compare
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
4 times, most recently
from
October 11, 2024 05:37
b8ea12e
to
c78fb7f
Compare
Prefetching breaks specs as they hit turbo_stream only requests
Otherwise, this breaks redireects from turbo, resulting in rendering empty html without a layout
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
from
October 11, 2024 07:31
c78fb7f
to
bbd4001
Compare
oliverguenther
force-pushed
the
experiment/enable-turbo-drive
branch
from
October 17, 2024 19:03
5723a0a
to
a4229e8
Compare
Local prevention of this error NoMethodError: undefined method `instantiate' for nil Shared Example Group: "a meetings tab" called from ./modules/meeting/spec/features/structured_meetings/work_package_meetings_tab_spec.rb:463 # ./app/models/custom_actions/conditions/role.rb:44:in `flatten'
with turbo: false, the form does not correctly get replaced in the current implementation, brekaing tests on upload attachment counting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://community.openproject.org/work_packages/57270
Known issues
Known broken tests
types/:id/edit/settings
) failing.